-
Notifications
You must be signed in to change notification settings - Fork 238
Docs for /metrics endpoint #2024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* [pprof](https://pkg.go.dev/net/http/pprof) profiling endpoints for CPU and memory profiling | ||
* Prometheus [/metrics](https://prometheus.io/docs/guides/go-application/#how-go-exposition-works) endpoint for exporting Go runtime metrics | ||
|
||
The k6 REST API must be enabled for these endpoints to be available (this is the default behavior). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was already added before, but I haven't found the documentation about how to disable the API. Do we really support it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can set it to an empty string and it will be disabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try to submit some docs for it as soon as possible tomorrow.
* [pprof](https://pkg.go.dev/net/http/pprof) profiling endpoints for CPU and memory profiling | ||
* Prometheus [/metrics](https://prometheus.io/docs/guides/go-application/#how-go-exposition-works) endpoint for exporting Go runtime metrics | ||
|
||
The k6 REST API must be enabled for these endpoints to be available (this is the default behavior). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can set it to an empty string and it will be disabled.
I would also recommend amending, if necessary, our versioning and support policy to explicit mention we do not officially support nor provide any guarantees around those endpoints as they are essentially external dependencies out of our control 🙇🏻 |
What?
It adds documentation for the new endpoint
/metrics
added when the option--profiling-enabled
. The pull request with the implementation grafana/k6#4944.Checklist
npm start
command locally and verified that the changes look good.docs/sources/k6/next
folder of the documentation.Related PR(s)/Issue(s)